-
Notifications
You must be signed in to change notification settings - Fork 158
feat(doc): add guidance for developers about using autoware evaluator #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@xmfcx I used the Others section for this documentation but I couldn't be sure if it is the correct place or not. |
ac6352a
to
3063f85
Compare
da57a7f
to
69b2b4b
Compare
69b2b4b
to
a80ee19
Compare
cc @xmfcx @mitsudome-r
Except for these points, the document is ready for review. If there is any missing point or possible improvement, let me know. |
a034c5d
to
695d322
Compare
cc @xmfcx @mitsudome-r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @brkay54 for the amazing efforts and the very useful documentation.
The documentation is easy to follow and very descriptive.
I have some minor comments that would be better to have a look to them before merging your PR.
Thanks again and let me know if you have any thoughts for my comments.
docs/how-to-guides/others/planning-evaluation-using-scenarios.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/others/planning-evaluation-using-scenarios.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/others/planning-evaluation-using-scenarios.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/others/planning-evaluation-using-scenarios.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
Signed-off-by: Berkay Karaman <berkay@leodrive.ai>
226b781
to
10cffa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge, any additional changes can be made in a separate PR.
Thanks for everyone's work.
Description
Related issue:
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.